[CI] Stabilise computing the list of changed files for ruff. #21068
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test Results0 tests 0 ✅ 0s ⏱️ Results for commit 29b7cca. ♻️ This comment has been updated with latest results. |
When a user branched from master a while ago, the diff step in the ruff action can compute the list of changed files wrongly. Here, we use the fact that the checkout action uses a merge commit on top of the target branch, so computing the diff between the last two commits encompasses all the files touched in the PR.
hageboeck
force-pushed
the
ruff_merge_base
branch
from
28b88c9 to
29b7cca
Compare
siliataider
added a commit
to siliataider/root
that referenced
this pull request
Feb 3, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a user branched from master a while ago, the diff step in the ruff action will compute the list of changed files wrongly. Here, we use the fact that the checkout action uses a merge commit on top of the target branch, so computing the diff between the last two commits encompasses all the files touched in the PR.
An example of the failure case can be seen in this PR: #20992
It doesn't touch any Python files, but the ruff check failed.